No implicit or explicit dependency on rncToXsd task causes caching to be disabled for some tasks
#13668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids configuring the task eagerly.
This addresses a deprecation warning causing build caching to be disabled for some tasks. With this change, we tell Gradle that the rncToXsd task produces output that should be considered a resource. This clears up ambiguities when computing the task graph.
This addresses a deprecation warning causing build caching to be disabled for the checkstyleNohttp task. With this change, we tell Gradle that the rncToXsd task in the spring-security-config project produces output that should be considered when running the checkstyleNohttp task. This clears up ambiguities when computing the task graph.
spring-projects-issues
added
the
status: waiting-for-triage
marcusdacoregio
added
in: build
|
Thank you, @erichaagdev. This has been merged via 4ebfa2c 620e6e0 and f026e29 into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses a deprecation warning causing caching to be disabled for some tasks. The deprecation is caused by
rncToXsdwriting files tosrc/main/resourcesof thespring-security-configproject. That directory is used as an input to several tasks, so there is ambiguity when computing the task graph. Gradle must therefore disable caching for these tasks.Prior to this change, a build scan would show us that caching for
rncToXsdis disabled to ensure correctness. We can also see the corresponding deprecation warnings. To resolve this, the output ofrncToXsdis wired to the main resources source set. This informs Gradle that it must executerncToXsdbefore any task using the main resources as an input.Resolving this deprecation warning caused the same issue for the
checkstyleNohttptask of the root project. To address this, thecheckstyleNohttptask is made aware of the output of therncToXsdtask fromspring-security-config. This makes sure therncToXsdtask is executed before running thecheckstyleNohttptask.Now with these changes, we can see caching is never disabled to ensure correctness and the deprecation warnings are gone. It's worth noting these deprecation warnings prevented the upgrade to Gradle 8.0. Only 2 deprecation warnings remain preventing the upgrade.