Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update document #15862

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Update document #15862

merged 1 commit into from
Oct 14, 2024

Conversation

ngocnhan-tran1996
Copy link
Contributor

I add breakline for easier reading

Before
image

After
image

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 28, 2024
@jzheaux
Copy link
Contributor

jzheaux commented Sep 30, 2024

Another good catch, @ngocnhan-tran1996! Will you please update the commit message to

  1. Capitalize the first word
  2. Describe what change was made

For example, you could do:

Add whitespace to improve readability

@jzheaux jzheaux self-assigned this Sep 30, 2024
@jzheaux jzheaux added in: docs An issue in Documentation or samples type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 30, 2024
@jzheaux jzheaux added this to the 6.4.0-RC1 milestone Sep 30, 2024
@jzheaux jzheaux modified the milestones: 6.4.0-RC1, 6.4.x Oct 14, 2024
@jzheaux jzheaux merged commit 35cc794 into spring-projects:main Oct 14, 2024
6 checks passed
@jzheaux
Copy link
Contributor

jzheaux commented Oct 14, 2024

Thanks, @ngocnhan-tran1996! This is now merged into main

@ngocnhan-tran1996 ngocnhan-tran1996 deleted the feature/update-document branch October 15, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jzheaux jzheaux

Labels
in: docs An issue in Documentation or samples type: enhancement A general enhancement
Projects
None yet
Milestone
6.4.0-RC1
Development

Successfully merging this pull request may close these issues.
3 participants
@ngocnhan-tran1996 @jzheaux @spring-projects-issues