Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set PublicKeyCredentialCreationOptionsRepository by DSL or Bean #16396

Closed
wants to merge 1 commit into from
Closed

Set PublicKeyCredentialCreationOptionsRepository by DSL or Bean #16396

wants to merge 1 commit into from

Conversation

kse-music
Copy link
Contributor

Closes gh-16369

Related to #16371

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 12, 2025
@kse-music kse-music mentioned this pull request Jan 14, 2025
Closed
@jzheaux jzheaux added in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 16, 2025
@rwinch rwinch added this to the 6.5.0-M1 milestone Jan 18, 2025
@rwinch rwinch added in: config An issue in spring-security-config in: web An issue in web modules (web, webmvc) and removed in: web An issue in web modules (web, webmvc) labels Jan 18, 2025
rwinch added a commit that referenced this pull request Jan 18, 2025
@rwinch
Add WebAuthenticationDsl.creationOptionsRepository
4314e68 
Issue gh-16396
rwinch added a commit that referenced this pull request Jan 18, 2025
@rwinch
Document PublicKeyCredentialCreationOptionsRepository
718c90d 
Issue gh-16396
@rwinch rwinch closed this in 683f1f4 Jan 18, 2025
@rwinch
Copy link
Member

rwinch commented Jan 18, 2025

Thanks for the Pull Request! This is now merged into main via the merge commit 683f1f4 😄

I included the original commit as 683f1f4 that was rebased along with additional polish:

  • 683f1f4 Set PublicKeyCredentialCreationOptionsRepository by DSL or Bean
  • 718c90d Document PublicKeyCredentialCreationOptionsRepository
  • 4314e68 Add WebAuthenticationDsl.creationOptionsRepository
  • bea2322 Fix whitespace
  • f4491f3 Set PublicKeyCredentialCreationOptionsRepository by DSL or Bean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rwinch rwinch

Labels
in: config An issue in spring-security-config in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement
Projects
None yet
Milestone
6.5.0-M1
Development

Successfully merging this pull request may close these issues.

Use dependency injection in webauthn filters to allow for customization
4 participants
@kse-music @rwinch @jzheaux @spring-projects-issues