darft of reactive Hazelcast session repository #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylancapraz
approved these changes
Nov 17, 2020
|
is there any plan for this task? |
|
Oh man, I hadn’t noticed this PR existed when I created #2222, you didn’t reference #831… Our implementations are very similar, except yours is for Hazelcast 3 and you chose to remove the support of application events. I guess both could be merged if they want to support both Hazelcast 3 and 4+ in 2.x (Hazelcast 3 support was removed in spring-session 3.x). |
|
Is there further decision making on this? Using Spring Boot 3.1.4 with spring session and spring cloud gateway and this is a blocker, since gateway uses Webflux. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provided a draft implementation of
HazelcastReactiveSessionRepositorywhich gives an asynchronous access to stored in Hazelcast sessions and may benefits resources utilization and apps performance.This PR is for running the discussion and possibly end up with final implementation that will be merged