-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Make QAction.setShortcut
and setShortcuts
accept many types
#461
Commits on Oct 18, 2023
-
Test
QMenu.addAction
with various shortcut typesTest `QMenu.addAction` with a shortcut of `Qt.Key` type as well. The argument type causes the following error on `PySide2`: ```plaintext TypeError: 'PySide2.QtWidgets.QAction.setShortcut' called with wrong argument types: PySide2.QtWidgets.QAction.setShortcut(Key) Supported signatures: PySide2.QtWidgets.QAction.setShortcut(PySide2.QtGui.QKeySequence) ```
Configuration menu - View commit details
-
Copy full SHA for df81709 - Browse repository at this point
Copy the full SHA df81709View commit details
Commits on Oct 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 019517c - Browse repository at this point
Copy the full SHA 019517cView commit details -
Make
QAction.setShortcut
(s
) accept many typesFix the omission of `Qt.Key` check. Fix a crash when `QAction.setShortcuts` gets a single shortcut. Add tests for the cases. Refactor a little.
Configuration menu - View commit details
-
Copy full SHA for 49f0b75 - Browse repository at this point
Copy the full SHA 49f0b75View commit details -
[pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
Configuration menu - View commit details
-
Copy full SHA for d6f2739 - Browse repository at this point
Copy the full SHA d6f2739View commit details -
Configuration menu - View commit details
-
Copy full SHA for bc7cc97 - Browse repository at this point
Copy the full SHA bc7cc97View commit details -
Configuration menu - View commit details
-
Copy full SHA for b4d3e1d - Browse repository at this point
Copy the full SHA b4d3e1dView commit details -
[pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
Configuration menu - View commit details
-
Copy full SHA for 80bb648 - Browse repository at this point
Copy the full SHA 80bb648View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c5100d - Browse repository at this point
Copy the full SHA 7c5100dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 849a349 - Browse repository at this point
Copy the full SHA 849a349View commit details -
Some 6.3.2 builds still seem to lack the flexibility.
Configuration menu - View commit details
-
Copy full SHA for d8afeb0 - Browse repository at this point
Copy the full SHA d8afeb0View commit details
Commits on Oct 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for a2451e1 - Browse repository at this point
Copy the full SHA a2451e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 674183d - Browse repository at this point
Copy the full SHA 674183dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 855e832 - Browse repository at this point
Copy the full SHA 855e832View commit details -
Configuration menu - View commit details
-
Copy full SHA for 429fd3d - Browse repository at this point
Copy the full SHA 429fd3dView commit details -
Test whether
QAction.setShortcuts
doesn't support aQt.Key
argume……nt as suggested by @ccordoba12 The test is expected to fail on Qt6 >= 6.5. The earlier versions of PyQt/PySide are patched against the fail, so don't test them.
Configuration menu - View commit details
-
Copy full SHA for 2c299ff - Browse repository at this point
Copy the full SHA 2c299ffView commit details -
[pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
Configuration menu - View commit details
-
Copy full SHA for c8d1144 - Browse repository at this point
Copy the full SHA c8d1144View commit details