-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Add QtCore.Qt.MouseButton.MidButton
alias for Qt6
#475
PR: Add QtCore.Qt.MouseButton.MidButton
alias for Qt6
#475
Conversation
If QtCore.Qt.MidButton works with QtPy and Qt6, then QtCore.Qt.MouseButton.MidButton is expected to work as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @PierreRaybaut ! Sorry for the late response and thank you for the fix! Could you also add the alias to the test at
qtpy/qtpy/tests/test_qtcore.py
Lines 172 to 190 in 3238de7
def test_enum_access(): | |
"""Test scoped and unscoped enum access for qtpy.QtCore.*.""" | |
assert ( | |
QtCore.QAbstractAnimation.Stopped | |
== QtCore.QAbstractAnimation.State.Stopped | |
) | |
assert QtCore.QEvent.ActionAdded == QtCore.QEvent.Type.ActionAdded | |
assert QtCore.Qt.AlignLeft == QtCore.Qt.AlignmentFlag.AlignLeft | |
assert QtCore.Qt.Key_Return == QtCore.Qt.Key.Key_Return | |
assert QtCore.Qt.transparent == QtCore.Qt.GlobalColor.transparent | |
assert QtCore.Qt.Widget == QtCore.Qt.WindowType.Widget | |
assert QtCore.Qt.BackButton == QtCore.Qt.MouseButton.BackButton | |
assert QtCore.Qt.XButton1 == QtCore.Qt.MouseButton.XButton1 | |
assert ( | |
QtCore.Qt.BackgroundColorRole | |
== QtCore.Qt.ItemDataRole.BackgroundColorRole | |
) | |
assert QtCore.Qt.TextColorRole == QtCore.Qt.ItemDataRole.TextColorRole | |
assert QtCore.Qt.MidButton == QtCore.Qt.MouseButton.MiddleButton |
?
Other than that this LGTM 👍 Thanks again!
@dalthviz, please push to this PR the fix you mentioned so we can include it in 2.4.2. |
QtCore.Qt.MouseButton.MidButton
alias for Qt6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @PierreRaybaut!
If QtCore.Qt.MidButton works with QtPy and Qt6, then QtCore.Qt.MouseButton.MidButton is expected to work as well.