Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add QtCore.Qt.MouseButton.MidButton alias for Qt6 #475

Merged

Conversation

PierreRaybaut
Copy link
Contributor

If QtCore.Qt.MidButton works with QtPy and Qt6, then QtCore.Qt.MouseButton.MidButton is expected to work as well.

If QtCore.Qt.MidButton works with QtPy and Qt6, then QtCore.Qt.MouseButton.MidButton is expected to work as well.
@coveralls
Copy link

Coverage Status

coverage: 96.781%. remained the same
when pulling bdbda26 on PR-Add-QtCore.Qt.MouseButton.MidButton-alias-for-Qt6
into 3238de7 on master.

@dalthviz dalthviz added this to the v2.4.2 milestone Apr 10, 2024
Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @PierreRaybaut ! Sorry for the late response and thank you for the fix! Could you also add the alias to the test at

def test_enum_access():
"""Test scoped and unscoped enum access for qtpy.QtCore.*."""
assert (
QtCore.QAbstractAnimation.Stopped
== QtCore.QAbstractAnimation.State.Stopped
)
assert QtCore.QEvent.ActionAdded == QtCore.QEvent.Type.ActionAdded
assert QtCore.Qt.AlignLeft == QtCore.Qt.AlignmentFlag.AlignLeft
assert QtCore.Qt.Key_Return == QtCore.Qt.Key.Key_Return
assert QtCore.Qt.transparent == QtCore.Qt.GlobalColor.transparent
assert QtCore.Qt.Widget == QtCore.Qt.WindowType.Widget
assert QtCore.Qt.BackButton == QtCore.Qt.MouseButton.BackButton
assert QtCore.Qt.XButton1 == QtCore.Qt.MouseButton.XButton1
assert (
QtCore.Qt.BackgroundColorRole
== QtCore.Qt.ItemDataRole.BackgroundColorRole
)
assert QtCore.Qt.TextColorRole == QtCore.Qt.ItemDataRole.TextColorRole
assert QtCore.Qt.MidButton == QtCore.Qt.MouseButton.MiddleButton

?

Other than that this LGTM 👍 Thanks again!

@ccordoba12 ccordoba12 modified the milestones: v2.4.2, v2.4.3 Oct 12, 2024
@ccordoba12 ccordoba12 modified the milestones: v2.4.3, v2.4.2 Oct 24, 2024
@ccordoba12
Copy link
Member

@dalthviz, please push to this PR the fix you mentioned so we can include it in 2.4.2.

@dalthviz dalthviz changed the title Add QtCore.Qt.MouseButton.MidButton alias for Qt6 PR: Add QtCore.Qt.MouseButton.MidButton alias for Qt6 Oct 24, 2024
@dalthviz dalthviz changed the title PR: Add QtCore.Qt.MouseButton.MidButton alias for Qt6 PR: Add QtCore.Qt.MouseButton.MidButton alias for Qt6 Oct 24, 2024
@coveralls
Copy link

coveralls commented Oct 24, 2024

Coverage Status

coverage: 90.18% (+0.02%) from 90.164%
when pulling 78d721e on PR-Add-QtCore.Qt.MouseButton.MidButton-alias-for-Qt6
into cc54a5e on master.

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PierreRaybaut!

@ccordoba12 ccordoba12 merged commit 2cc5fc4 into master Oct 24, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants