Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Add
QT_VERSION
environment variable #478base: master
Are you sure you want to change the base?
PR: Add
QT_VERSION
environment variable #478Changes from 3 commits
3ec1785
1d398fc
abc95b2
b8c9d20
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not totally sure but, I think we are not setting the
QT_VERSION
env var over the CI so for the moment this test is passing without doing any assert?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I don't think
QT_VERSION
is set in CI, ideally both possibilities should be checked. Do you happen to know how this works for the similar testtest_qt_api
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think currently the
test_qt_api
is going through theelse
branch 😅 Checking the script that does the test setup (test.sh) I'm not seeing us setting upQT_API
🤔 Maybe we should try to check a way to setupQT_API
(andQT_VERSION
) for the tests (I think there is aUSE_QT_API
that can be set for test but I think we are not using it here either). What do you think @ccordoba12 ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also think that's a good idea but I don't understand very well how to set up those env vars in our CIs.