PR: Remove useless shebang lines #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since these files do not have the executable bit set in their file permissions, the shebang line (#!) does nothing. For qtsass/cli.py, the file is not even script-like (the “main routine” is only defined, not called, on import). For the other three, setting the executable bit *could* be an alternative, if people wanted to run e.g. “./run_checks_and_format.py” instead of “python3 run_checks_and_format.py”.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #76 +/- ##
=======================================
Coverage 92.20% 92.20%
=======================================
Files 12 12
Lines 577 577
=======================================
Hits 532 532
Misses 45 45
☔ View full report in Codecov by Sentry. |
dalthviz
changed the title
dalthviz
approved these changes
Sep 11, 2023
|
Thanks for the quick review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since these files do not have the executable bit set in their file permissions, the shebang line (
#!) does nothing.For
qtsass/cli.py, the file is not even script-like (the “main routine” is only defined, not called, on import).For the other three, setting the executable bit could be an alternative, if people wanted to run e.g. “
./run_checks_and_format.py” instead of “python3 run_checks_and_format.py”.