Remove some common table/field names from PostgreSQL keywords

Fixes #156
sql-formatter-org · Dec 7, 2023 · d34557b · d34557b
1 parent cd7ec6c
commit d34557b
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 7 deletions.
diff --git a/src/languages/postgresql/postgresql.keywords.ts b/src/languages/postgresql/postgresql.keywords.ts
@@ -191,7 +191,6 @@ export const keywords: string[] = [
   'ISOLATION',
   'JOIN', // reserved (can be function or type)
   'KEY',
-  'LABEL',
   'LANGUAGE',
   'LARGE',
   'LAST',
@@ -208,7 +207,6 @@ export const keywords: string[] = [
   'LOCAL',
   'LOCALTIME', // reserved
   'LOCALTIMESTAMP', // reserved
-  'LOCATION',
   'LOCK',
   'LOCKED',
   'LOGGED',
@@ -222,8 +220,6 @@ export const keywords: string[] = [
   'MODE',
   'MONTH', // requires AS
   'MOVE',
-  'NAME',
-  'NAMES',
   'NATIONAL', // (cannot be function or type)
   'NATURAL', // reserved (can be function or type)
   'NCHAR', // (cannot be function or type)
@@ -302,7 +298,6 @@ export const keywords: string[] = [
   'REFRESH',
   'REINDEX',
   'RELATIVE',
-  'RELEASE',
   'RENAME',
   'REPEATABLE',
   'REPLACE',
@@ -384,8 +379,6 @@ export const keywords: string[] = [
   'TRUE', // reserved
   'TRUNCATE',
   'TRUSTED',
-  'TYPE',
-  'TYPES',
   'UESCAPE',
   'UNBOUNDED',
   'UNCOMMITTED',

diff --git a/test/postgresql.test.ts b/test/postgresql.test.ts
@@ -312,4 +312,19 @@ describe('PostgreSqlFormatter', () => {
         items;
     `);
   });
+
+  // Issue #156
+  it('does not recognize common fields names as keywords', () => {
+    expect(format(`SELECT id, type, name, location, label FROM release;`, { keywordCase: 'upper' }))
+      .toBe(dedent`
+      SELECT
+        id,
+        type,
+        name,
+        location,
+        label
+      FROM
+        release;
+    `);
+  });
 });