-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: [testing] Mic/todos in moderators fix #56
Conversation
Signed-off-by: Adrian Cole <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
actually this has the wrong model thing again..
|
@codefromthecrypt hrm - yes same as last time. Is this same bug? I am totally confused |
src/exchange/exchange.py
Outdated
@@ -40,7 +40,7 @@ class Exchange: | |||
provider: Provider | |||
model: str | |||
system: str | |||
moderator: Moderator = field(default=ContextTruncate()) | |||
moderator: Moderator = field(default=ContextSummarizer()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's remove this default so there's no chance of setting it wrong (e.g. better to error due to not inheriting model than using wrong one)
class ContextSummarizer(ContextTruncate):
def __init__(
self,
model: str = "gpt-4o-mini",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, or it needs to be fixed to take in the correct model
adding in fixes from #54 to try to fix broken test on #52
Also, we can't default to contextsummarizer while it hard codes gpt4o #57