Handle source close while reading on Pipe

[nicolashaan]

Handle source close while reading on Pipe.
Does it look like a legit behavior to implement?

[swankjesse]

It’s not safe to close a source you’re currently reading. You want pipe.cancel() instead.

[nicolashaan]

I understand this is not safe but the API is allowing it anyway.
Then why not mimic the behavior of Java socket that throws in such a case, and where closing the input stream is closing the socket?
At this moment the read will block indefinitely until the Sink is closed or the Pipe is cancelled.

[swankjesse]

We’d be better off if we had a Source.cancel() API, but I didn’t do that at the time.

Java’s InputStream uses synchronized to kind of support this, but we also don’t do synchronized in Okio. This is a feature!