1247: WIP: Partial Tree Rerendering #1248
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steve-the-edwards
force-pushed
the
sedwards/partial-tree
branch
from
a393b93 to
0514919
Compare
steve-the-edwards
changed the base branch from
main
to
sedwards/cache-render-context
steve-the-edwards
force-pushed
the
sedwards/cache-render-context
branch
2 times, most recently
from
6f2d156 to
74fb6fb
Compare
steve-the-edwards
force-pushed
the
sedwards/partial-tree
branch
from
0514919 to
7c724a3
Compare
steve-the-edwards
force-pushed
the
sedwards/cache-render-context
branch
from
74fb6fb to
c7d7c15
Compare
steve-the-edwards
force-pushed
the
sedwards/partial-tree
branch
from
06bf903 to
e1f220c
Compare
steve-the-edwards
force-pushed
the
sedwards/cache-render-context
branch
2 times, most recently
from
0a36563 to
717d484
Compare
steve-the-edwards
force-pushed
the
sedwards/partial-tree
branch
3 times, most recently
from
7d7098f to
b6e677c
Compare
| return flow.value | ||
| context.runningWorker(rerenderWorker) { output: T -> | ||
| action("rerenderUpdate") { | ||
| state = output |
There was a problem hiding this comment.
prior to this state was not actually changing - so this would not work in the optimized runtime.
steve-the-edwards
force-pushed
the
sedwards/partial-tree
branch
2 times, most recently
from
8647d68 to
e99c6b6
Compare
steve-the-edwards
force-pushed
the
sedwards/cache-render-context
branch
from
717d484 to
646ebf7
Compare
steve-the-edwards
force-pushed
the
sedwards/partial-tree
branch
3 times, most recently
from
e4a227d to
6560454
Compare
Track whether or not the state (or state of a child) has changed in the WorkflowNode. Pass lastRendering if its not.
steve-the-edwards
force-pushed
the
sedwards/partial-tree
branch
from
6560454 to
3a5f35a
Compare
steve-the-edwards
force-pushed
the
sedwards/partial-tree
branch
from
3a5f35a to
f888f1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-render the node only if:
In order to do this, we have to propagate the action cascade all the way up to the root to record a single path of changed nodes.
Note we currently do not re-render if the workflow instance changed (unless the state also changed!), assuming the new workflow is still compatible with the old rendering because its identifier did not change.
Closes #1247.