1249: Cache Intercepted Workflow Instance #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steve-the-edwards
force-pushed
the
sedwards/cache-it-all
branch
2 times, most recently
from
1c12e26 to
1bf6f2f
Compare
steve-the-edwards
requested review from
zach-klippenstein and
a team
as code owners
steve-the-edwards
added
the
optimization
steve-the-edwards
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
steve-the-edwards
force-pushed
the
sedwards/cache-it-all
branch
from
1bf6f2f to
a7dab3d
Compare
steve-the-edwards
force-pushed
the
sedwards/cache-it-all
branch
from
a7dab3d to
8e40b8a
Compare
zach-klippenstein
approved these changes
Jan 27, 2025
| @@ -202,6 +205,18 @@ internal class WorkflowNode<PropsT, StateT, OutputT, RenderingT>( | |||
| coroutineContext.cancel(cause) | |||
| } | |||
|
|
|||
| // Call this after we have been passed any workflow instance, in [render] or [snapshot]. It may | |||
| // have changed and we should check to see if we need to update our cached instances. | |||
There was a problem hiding this comment.
Nit: Make this a kdoc comment so it's visible directly at callsites.
| if (workflow !== cachedWorkflowInstance) { | ||
| // instance has changed. | ||
| interceptedWorkflowInstance = interceptor.intercept(workflow, this) | ||
| cachedWorkflowInstance = workflow |
There was a problem hiding this comment.
Why do you update cachedWorkflowInstance first in init, but second here? Is there some case where intercept needs the cached workflow to not be updated yet?
There was a problem hiding this comment.
nope. Just a coincidence. I can unify the order so its not confusing.
Change it if we have been passed a new workflow instance to the same node.
steve-the-edwards
force-pushed
the
sedwards/cache-it-all
branch
from
8e40b8a to
2e43d2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cache the instance of the workflow before and after it is intercepted.
We check for instance equality any time a new workflow instance is passed in (
render()andsnapshot()) and we update our cached instances when that happens. This will allow us to continue to use the sameWorkflowNodewith different instances of the workflow.Closes #1249