Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Http::Stream::reply to Pointer #1855

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Upgrade Http::Stream::reply to Pointer #1855

wants to merge 3 commits into from
+35 −46

Conversation

yadij
Copy link
Contributor

@yadij yadij commented Jun 29, 2024

Refactor to avoid storing a raw-pointer, with
missing reference-counting.

@kinkie
Copy link
Contributor

kinkie commented Jun 29, 2024

This PR seems to contain spurious changes

@rousskov rousskov self-requested a review June 29, 2024 12:33
@rousskov rousskov changed the title Update Http::Stream::reply to Pointer Upgrade Http::Stream::reply to Pointer Jun 29, 2024
rousskov
rousskov requested changes Jun 29, 2024
View reviewed changes
Copy link
Contributor

@rousskov rousskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this upgrade.

I replaced "update" with "upgrade" in PR title because the latter feels more precise and arguably self-documents the motivation behind this PR. Please undo if you think "update" is better.

src/http/Stream.cc Outdated Show resolved Hide resolved
src/http/Stream.cc Outdated Show resolved Hide resolved
src/http/Stream.cc Outdated Show resolved Hide resolved
src/http/Stream.cc Show resolved Hide resolved
src/http/Stream.cc Show resolved Hide resolved
@rousskov rousskov added the S-waiting-for-author author action is expected (and usually required) label Jun 29, 2024
@squid-anubis squid-anubis added M-failed-other https://github.com/measurement-factory/anubis#pull-request-labels and removed M-failed-other https://github.com/measurement-factory/anubis#pull-request-labels labels Aug 20, 2024
@yadij
Update Http::Stream::reply to Pointer
2e0f637 
Refactor to avoid storing a raw-pointer, with
missing reference-counting.
@yadij
Copy link
Contributor Author

yadij commented Nov 16, 2024

Rebased on master without ESI and related callback complications.

@yadij yadij added S-waiting-for-reviewer ready for review: Set this when requesting a (re)review using GitHub PR Reviewers box and removed S-waiting-for-author author action is expected (and usually required) labels Nov 16, 2024
@yadij yadij requested a review from rousskov November 16, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousskov rousskov Awaiting requested review from rousskov

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
S-waiting-for-reviewer ready for review: Set this when requesting a (re)review using GitHub PR Reviewers box
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yadij @kinkie @rousskov @squid-anubis