Replace MEM_DREAD_CTRL pool with MEMPROXY class pool #1924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rousskov
changed the title
rousskov
requested changes
Oct 28, 2024
There was a problem hiding this comment.
I adjusted PR title/description to match recent commit ed1a732.
Before advancing this new PR (including fixing build tests) and requesting my re-review, please cooperate to merge PRs awaiting your review for a long time, including these three:
- Upgrade generated parse_line() to accept constant SBuf #1840 opened Jun 11, 2024: "Upgrade generated parse_line() to accept constant SBuf"
- Bug 5363: Handle IP-based X.509 SANs better #1793 opened Apr 25, 2024: "Bug 5363: Handle IP-based X.509 SANs better"
- Bug 5383: handleNegotiationResult() level-2 debugs() crash #1856 opened Jun 30, 2024: "Bug 5383: handleNegotiationResult() level-2 debugs() crash"
rousskov
added
the
S-waiting-for-author
... to a MEMPROXY class pool. Replacing memory allocate and destruct with C++ new/delete and in-class initialization.
Co-authored-by: Alex Rousskov <[email protected]>
yadij
added
S-waiting-for-reviewer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing memory allocate and destruct with C++ new/delete
and in-class initialization.