-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates and Fixes to Make spark-memory work on opensource spark #4
base: master
Are you sure you want to change the base?
Conversation
…vented spark from stating the ExecutorPlugin cr https://code.amazon.com/reviews/CR-12240438
…mple error message generated by Yarn
…s were implemented
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this -- yes it totally makes sense, this was last updated before the api was finalized.
Other than removing the extra file, this looks good, thanks!
@@ -0,0 +1,37 @@ | |||
# -*-perl-*- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you remove this file from the pr please?
Also btw, a lot of the functionality of this plugin was recently merged to master in apache spark (SPARK-26329 / apache/spark#23767). Its not exactly the same -- that makes it easier to capture metrics at a faster rate and still include something reasonable in the event logs. But the major problem with that approach is we don't get any info from right before the executor gets killed suddenly. |
Updates and Fixes to Make spark-memory work on opensource spark