Report download #235
Open
Report download #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 15, 2018 13:54
Clicking the button will download a CSV file with the results.
pmcelhaney
commented
Oct 15, 2018
| } | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
This whole section needs to be deleted.
pmcelhaney
commented
Oct 15, 2018
| @@ -9,6 +9,7 @@ _global.translation['en'] = { | |||
| ,"auditor_select_types" : 'Select the types of issues to include in the report' | |||
| ,"auditor_home" : 'Home' | |||
| ,"auditor_view_report" : 'View Report' | |||
| ,"auditor_download_report": 'Download Report' | |||
There was a problem hiding this comment.
This can go. I ended up making the label "CSV" which is language-independent.
pmcelhaney
commented
Oct 15, 2018
| * Runs the sniffs and downloads the results to a text file | ||
| * | ||
| */ | ||
| _global.downloadHTMLCS = function () { |
There was a problem hiding this comment.
Should be part of the HTMLCS object.
|
Just a note that the main developer on this project is on leave for the next several weeks, so PRs will be stalled. |
|
I've put this into branch 'pmcelhaney-report-download' for now with a few changes. Will look at a merge after more testing and confirmation of the location we would add the button to download (It looks ok where it is imho, but visually it doesn't look clickable so I'll get some input from other colleagues first). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a "CSV" button in the top right corner of the summary view. Clicking the button downloads the results in a CSV file.
The code needs to be cleaned up and I haven't thoroughly tested yet, but I want to go ahead and get this out there so that I can start collecting feedback.
Issue #111