Update python.cc #123
Open
Update python.cc #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missing surrounding parenthesis for if statement on PyTuple_Check for python 3.9 or some versions of DCMAKE or CUDA_ARCH causes a build error.
|
Thanks, @mooresethmoore! Would you kindly sign the DCO. |
mooresethmoore
commented
Jan 30, 2022
There was a problem hiding this comment.
Missing surrounding parenthesis for if statement on PyTuple_Check for python 3.9 or some versions of DCMAKE or CUDA_ARCH causes a build error.
Signed-off-by: Seth Moore [email protected]
|
Compiled successfully with this patch. Thank you! |
|
@vmarkovtsev are there any plans on merging this? It solved my compilation problem under python 3.9. |
|
@vincentmaye If you could copy this fix in another PR and accept DCO, I will immediately merge it 🙏 You see, I've got a strong requirement for license purity and cannot accept patches without signed-off-by. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing surrounding parenthesis for if statement on PyTuple_Check for python 3.9 or some versions of DCMAKE or CUDA_ARCH causes a build error.
Signed-off-by: Seth Moore [email protected]