Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace FhirPathFunction documentation string with a class #84

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

camemre49
Copy link

@camemre49 camemre49 commented Jan 21, 2025

The FhirPathFunction documentation was previously managed using a string containing all emojis, formats, and tags, which made it difficult to handle. This string has been replaced with a more organized data structure, and the corresponding annotation parser function is updated

@dogukan10
Copy link
Contributor

For the function max, we have this return type: Seq(FHIR_DATA_TYPES.STRING, "number", FHIR_DATA_TYPES.DATETIME, FHIR_DATA_TYPES.TIME, "quantity")

I see that we do not have quantity or number in FHIR_DATA_TYPES but can we use FHIR_DATA_TYPES.QUANTITY and FHIR_DATA_TYPES.DECIMAL ? Does it break any functionality on the web ?

@camemre49 camemre49 force-pushed the fhir-path-function-data-types-enum branch from a49f23b to 5aa8412 Compare January 30, 2025 08:15
@camemre49
Copy link
Author

For the function max, we have this return type: Seq(FHIR_DATA_TYPES.STRING, "number", FHIR_DATA_TYPES.DATETIME, FHIR_DATA_TYPES.TIME, "quantity")

I see that we do not have quantity or number in FHIR_DATA_TYPES but can we use FHIR_DATA_TYPES.QUANTITY and FHIR_DATA_TYPES.DECIMAL ? Does it break any functionality on the web ?

For the function max, we have this return type: Seq(FHIR_DATA_TYPES.STRING, "number", FHIR_DATA_TYPES.DATETIME, FHIR_DATA_TYPES.TIME, "quantity")

I see that we do not have quantity or number in FHIR_DATA_TYPES but can we use FHIR_DATA_TYPES.QUANTITY and FHIR_DATA_TYPES.DECIMAL ? Does it break any functionality on the web ?

They can be replaced without any problem. return type and input type fields are not used on the web.

@camemre49 camemre49 force-pushed the fhir-path-function-data-types-enum branch from 5aa8412 to 196c996 Compare January 30, 2025 11:31
@camemre49 camemre49 force-pushed the fhir-path-function-data-types-enum branch from 196c996 to 126c3f2 Compare February 11, 2025 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants