♻️ Refactor(FhirMappingJobExecution): Add an apply method to s… #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camemre49
commented
Jun 26, 2024
tofhir-engine/src/main/scala/io/tofhir/engine/mapping/FhirMappingJobManager.scala
Show resolved
Hide resolved
camemre49
force-pushed
the
simplify-mapping-job-execution
branch
from
4a404ad to
f89ae3a
Compare
dogukan10
force-pushed
the
simplify-mapping-job-execution
branch
from
ea56234 to
97934ab
Compare
dogukan10
requested changes
Jun 28, 2024
tofhir-engine/src/main/scala/io/tofhir/engine/model/FhirMappingJobExecution.scala
Show resolved
Hide resolved
camemre49
force-pushed
the
simplify-mapping-job-execution
branch
from
8230773 to
6fdd369
Compare
camemre49
force-pushed
the
simplify-mapping-job-execution
branch
4 times, most recently
from
a72f216 to
f05598f
Compare
dogukan10
requested changes
Jul 2, 2024
tofhir-engine/src/main/scala/io/tofhir/engine/execution/FileStreamInputArchiver.scala
Outdated
Show resolved
Hide resolved
tofhir-engine/src/main/scala/io/tofhir/engine/execution/FileStreamInputArchiver.scala
Outdated
Show resolved
Hide resolved
tofhir-engine/src/main/scala/io/tofhir/engine/model/FhirMappingJobExecution.scala
Outdated
Show resolved
Hide resolved
tofhir-engine/src/main/scala/io/tofhir/engine/model/FhirMappingJobExecution.scala
Show resolved
Hide resolved
tofhir-engine/src/main/scala/io/tofhir/engine/model/FhirMappingJobExecution.scala
Outdated
Show resolved
Hide resolved
tofhir-engine/src/main/scala/io/tofhir/engine/model/FhirMappingJobExecution.scala
Outdated
Show resolved
Hide resolved
tofhir-engine/src/main/scala/io/tofhir/engine/model/FhirMappingJobExecution.scala
Show resolved
Hide resolved
dogukan10
approved these changes
Jul 3, 2024
… FhirMappingJobExecution by removing job from definition
… by removing sourceSettings
…factor related code
dogukan10
force-pushed
the
simplify-mapping-job-execution
branch
from
e9a61d8 to
97f0005
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed job model from the definition of FhirMappingJobExecution to simplify it.