Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor file format to content type #226

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Refactor file format to content type #226

merged 2 commits into from
Sep 23, 2024

Conversation

Okanmercan99
Copy link
Contributor

No description provided.

@Okanmercan99 Okanmercan99 marked this pull request as ready for review September 18, 2024 09:13
@Okanmercan99
Copy link
Contributor Author

Okanmercan99 commented Sep 18, 2024 •
edited
Loading

image
For this update, you should change the fileFormat field to contentType. Additionally, you should add the contentType field to all sources that are FileSystemSource .

@Okanmercan99
Copy link
Contributor Author

image
You should add the contentType field to all sinkSettings that are FileSystemSinkSettings.

@dogukan10 dogukan10 added the migration-script This pull request includes changes that require a migration script. label Sep 20, 2024
@dogukan10

This comment was marked as resolved.

Sign in to view
@Okanmercan99 Okanmercan99 force-pushed the refactor-fileFormat-to-contentType branch from 887cfa9 to 2087da4 Compare September 20, 2024 13:07
@dogukan10 dogukan10 force-pushed the refactor-fileFormat-to-contentType branch from 2087da4 to 17b57e7 Compare September 20, 2024 13:17
dogukan10
dogukan10 requested changes Sep 23, 2024
View reviewed changes
@Okanmercan99 Okanmercan99 force-pushed the refactor-fileFormat-to-contentType branch from 565b506 to 606b0ce Compare September 23, 2024 11:07
@Okanmercan99 Okanmercan99 force-pushed the refactor-fileFormat-to-contentType branch from 606b0ce to de03269 Compare September 23, 2024 11:08
@dogukan10 dogukan10 merged commit f93b95a into main Sep 23, 2024
1 check passed
@dogukan10 dogukan10 deleted the refactor-fileFormat-to-contentType branch September 23, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dogukan10 dogukan10 dogukan10 approved these changes

Assignees
No one assigned
Labels
migration-script This pull request includes changes that require a migration script.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Okanmercan99 @dogukan10