✨ feat: Infer required fields. #278
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Okanmercan99
force-pushed
the
infer-cardinality
branch
from
35f3aab to
03bf066
Compare
Okanmercan99
force-pushed
the
infer-cardinality
branch
from
03bf066 to
5f01db0
Compare
Okanmercan99
force-pushed
the
infer-cardinality
branch
from
5f01db0 to
4c51986
Compare
YemreGurses
reviewed
Jan 23, 2025
| @@ -114,7 +115,6 @@ class SchemaDefinitionService(schemaRepository: ISchemaRepository, mappingReposi | |||
| val dataFrame = try { | |||
| SourceHandler | |||
| .readSource(inferTask.name, ToFhirConfig.sparkSession, inferTask.sourceBinding, inferTask.mappingJobSourceSettings.head._2, schema = None) | |||
| .limit(1) // It is enough to take the first row to infer the schema. | |||
There was a problem hiding this comment.
Understood that this is removed to infer the column is required or not. But, if we make inferring using a large CSV, will we have performance problems because it reads all?
There was a problem hiding this comment.
How can we determine if a column is mandatory without reviewing all rows? We need to ensure that every row contains a specific value for this column to confirm its necessity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.