Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply 'patches' after 'buildFromSdist' #291

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

srid
Copy link
Owner

@srid srid commented Apr 2, 2024

Resolves #290

@roberth
Copy link
Collaborator

roberth commented Apr 2, 2024

That's a bit surprising. I'd only use buildFromSdist on local packages, and then it doesn't make much sense to add patches.
I suppose it could happen when importing a haskell-flake module from a dependency?

I don't have an opinion on whether patches should be applied before or after sdist. When applied before, the patches can be used to fix the creation of the sdist, whereas if you apply them after the sdist, you can fix the effects of a broken sdist.
I suppose the latter matches what you would do with a package from hackage, so I guess that might be a reason to prefer that.

@srid
Copy link
Owner Author

srid commented Apr 3, 2024

I'd only use buildFromSdist on local packages

Actually, that makes more sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Patches are applied twice if buildFromSDist is enabled
2 participants