Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charm logging with structured fields #2449

Merged
merged 17 commits into from
Feb 5, 2025
Merged

Charm logging with structured fields #2449

merged 17 commits into from
Feb 5, 2025

Conversation

hellt
Copy link
Member

@hellt hellt commented Feb 5, 2025

@hellt hellt changed the title Charm logging Charm logging with structured fields Feb 5, 2025
@hellt hellt marked this pull request as ready for review February 5, 2025 15:20
@hellt hellt merged commit f861ff6 into main Feb 5, 2025
66 of 67 checks passed
@hellt hellt deleted the charm-log branch February 5, 2025 15:36
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 75.38462% with 16 lines in your changes missing coverage. Please review.

Project coverage is 52.48%. Comparing base (3685113) to head (56ccc48).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
nodes/vr_sros/vr-sros.go 0.00% 12 Missing ⚠️
clab/config/template.go 0.00% 1 Missing ⚠️
clab/config/utils.go 0.00% 1 Missing ⚠️
cmd/config.go 0.00% 1 Missing ⚠️
cmd/inspect/inspect_interfaces.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2449      +/-   ##
==========================================
+ Coverage   52.37%   52.48%   +0.10%     
==========================================
  Files         172      172              
  Lines       17582    17614      +32     
==========================================
+ Hits         9209     9245      +36     
+ Misses       7404     7398       -6     
- Partials      969      971       +2     
Files with missing lines Coverage Δ
cert/certificate.go 37.25% <ø> (ø)
clab/authz_keys.go 53.57% <ø> (ø)
clab/clab.go 69.73% <100.00%> (ø)
clab/config.go 68.16% <100.00%> (ø)
clab/config/transport/ssh.go 0.00% <ø> (ø)
clab/config/transport/sshkind.go 0.00% <ø> (ø)
clab/dependency_manager/dependency_manager.go 97.14% <ø> (ø)
clab/dependency_manager/dependency_node.go 84.21% <ø> (ø)
clab/deploy_options.go 68.00% <ø> (ø)
clab/exec/exec.go 64.38% <100.00%> (+2.61%) ⬆️
... and 94 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant