Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user to clab_admins group #2452

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Add user to clab_admins group #2452

merged 2 commits into from
Feb 10, 2025

Conversation

kaelemc
Copy link
Contributor

@kaelemc kaelemc commented Feb 6, 2025

Add the user to the clab_admins group for sudoless clab operation as per v0.64.

Also a new var CLAB_ADMINS. Similar to the SETUP_SSHD, it will default to true. If it is not true, then user won't be added to clab_admins.

PR is in draft state while I test a few things.

- Add env var `CLAB_ADMINS`. Defaults to `true`. If set to anything else it will not add the user to the `clab_admins` group.
@kaelemc kaelemc marked this pull request as ready for review February 6, 2025 20:37
@hellt hellt merged commit f1a3384 into srl-labs:main Feb 10, 2025
3 checks passed
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.45%. Comparing base (f861ff6) to head (66fdd83).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2452      +/-   ##
==========================================
- Coverage   52.48%   52.45%   -0.04%     
==========================================
  Files         172      172              
  Lines       17614    17614              
==========================================
- Hits         9245     9239       -6     
- Misses       7398     7404       +6     
  Partials      971      971              

see 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants