Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error if get.sh download fails #2477

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Error if get.sh download fails #2477

merged 1 commit into from
Feb 20, 2025

Conversation

hellt
Copy link
Member

@hellt hellt commented Feb 20, 2025

fix #2100

@hellt hellt merged commit 661e3cc into main Feb 20, 2025
8 checks passed
@hellt hellt deleted the check-dwnl-error branch February 20, 2025 11:17
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 52.60%. Comparing base (d54989c) to head (5c99074).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/version/upgrade.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2477      +/-   ##
==========================================
+ Coverage   52.56%   52.60%   +0.04%     
==========================================
  Files         172      172              
  Lines       17690    17692       +2     
==========================================
+ Hits         9298     9307       +9     
+ Misses       7414     7410       -4     
+ Partials      978      975       -3     
Files with missing lines Coverage Δ
cmd/version/upgrade.go 5.26% <0.00%> (-0.30%) ⬇️

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No error message when version upgrade fails (no Internet connectivity)
1 participant