Update risk assesments #600
Conversation
There was a problem hiding this comment.
nit: the mix of underscores and dashes here feels weird. It looks like we've used underscores in risk assessment file names in the past, perhaps we could stick with that?
risk-assessments.md
Outdated
| If you have any questions please contact us at [{{ site.emails.teams }}][teams-email]. | ||
|
|
||
| [teams-email]: mailto:{{ site.emails.teams }} |
There was a problem hiding this comment.
Please can we keep this footer? (about contacting us if any questions)
risk-assessments.md
Outdated
| If you have any questions please contact us at [{{ site.emails.teams }}][teams-email]. | ||
|
|
||
| [teams-email]: mailto:{{ site.emails.teams }} | ||
| This year our Tech Days are taking place in two different locations. We have published a risk assessment for both [Cambridge]({{ '/resources/sr2025/risk-assessments/cambridge_tech-day.pdf' | prepend: site.baseurl }}) and [Horsham]({{ '/resources/sr2025/risk-assessments/horsham_tech-day.pdf' | prepend: site.baseurl }}) |
There was a problem hiding this comment.
Missing full stop at the end of this sentence?
| This year our Tech Days are taking place in two different locations. We have published a risk assessment for both [Cambridge]({{ '/resources/sr2025/risk-assessments/cambridge_tech-day.pdf' | prepend: site.baseurl }}) and [Horsham]({{ '/resources/sr2025/risk-assessments/horsham_tech-day.pdf' | prepend: site.baseurl }}) | |
| This year our Tech Days are taking place in two different locations. We have published a risk assessment for both [Cambridge]({{ '/resources/sr2025/risk-assessments/cambridge_tech-day.pdf' | prepend: site.baseurl }}) and [Horsham]({{ '/resources/sr2025/risk-assessments/horsham_tech-day.pdf' | prepend: site.baseurl }}). |
There was a problem hiding this comment.
Meta for future: when importing files from other sources it's generally a good idea to include in the commit message what the source was. This both helps review (means that reviewers can just check that the file matches what the source was rather than having to review the whole content) and means that future updates are easier (since getting back to the source is easier).
For now just adding the links to the PR is probably enough, though if you wanted to edit the commit to add the links that's also an option.
There was a problem hiding this comment.
Thanks, I'll remember that in future. Not sure how to edit commits.
I believe this closes out the last part of srobo/tasks#1476