Skip to content

Commit

Permalink
Fixes #14. Also removed now unecessary preconditions, because they ar…
Browse files Browse the repository at this point in the history
…e either set in the defaults or in set-role-variables.
  • Loading branch information
srsp committed Jul 19, 2018
1 parent efe5b42 commit 61ad0b2
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 17 deletions.
8 changes: 0 additions & 8 deletions tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,6 @@
fail: msg="ERROR - required variable 'java_version' missing."
when: java_version is not defined

- name: precondition - java_subversion
fail: msg="ERROR - required variable 'java_subversion' missing."
when: java_subversion is not defined

- name: precondition - java_install_jce
fail: msg="ERROR - required variable 'java_install_jce' missing."
when: java_install_jce is not defined

- include: set-role-variables.yml


Expand Down
20 changes: 14 additions & 6 deletions tasks/set-role-variables.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,22 +4,30 @@
#


- name: set general internal vars for {{ java_version }}
- name: set general internal vars for java 8
set_fact:
jdk_version: "1.{{ java_version }}.0_{{ java_subversion }}"
when: java_version == 8

- name: set general internal vars for {{ java_version }}
- name: set java subversion java 9
set_fact:
# JDK 9 is only available in 9.0.4
jdk_subversion: 0.4
java_subversion: 0.4
when: java_version == 9

- name: set general internal vars for java 9
set_fact:
jdk_version: "{{ java_version }}.{{ java_subversion }}"
when: java_version == 9

- name: set general internal vars for {{ java_version }}
- name: set java subversion for java 10
set_fact:
# JDK 10 is only available in 10.0.2
java_subversion: 0.2
when: java_version == 10

- name: set general internal vars for java 10
set_fact:
# JDK 10 is only available in 10.0.1
jdk_subversion: 0.1
jdk_version: "{{ java_version }}.{{ java_subversion }}"
when: java_version == 10

Expand Down
2 changes: 0 additions & 2 deletions test_10.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,10 @@
# vars from defaults/main.yml
vars:
- java_version: 10
- java_subversion: 0.1

- java_download_path: /tmp
- java_download_from_oracle: true
- java_remove_download: false
- java_install_jce: false
- java_mirror: http://download.oracle.com/otn-pub/java

- java_set_javahome: false
1 change: 0 additions & 1 deletion test_9.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
# vars from defaults/main.yml
vars:
java_version: 9
java_subversion: 0.4

java_download_path: /tmp
java_download_from_oracle: true
Expand Down

0 comments on commit 61ad0b2

Please sign in to comment.