code analysis fixes

ssg · Jul 11, 2023 · fb6cc96 · fb6cc96
1 parent f973fa4
commit fb6cc96
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 5 deletions.
diff --git a/.editorconfig b/.editorconfig
@@ -0,0 +1,4 @@
+[*.cs]
+
+# IDE1006: Naming Styles
+dotnet_diagnostic.IDE1006.severity = silent
diff --git a/BoolToColorConverter.cs b/BoolToColorConverter.cs
@@ -29,7 +29,7 @@ public object Convert(object value, Type targetType, object parameter, CultureIn
 
         public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture)
         {
-            return value.ToString() == "Green" ? true : false;
+            return value.ToString() == "Green";
         }
     }
 }
diff --git a/GameController.cs b/GameController.cs
@@ -92,7 +92,7 @@ private void changeStateInBackground(string verb, GameControllerState newState,
             const string standardArguments = "-InformationAction SilentlyContinue -PassThru -Confirm:$false";
 
             ErrorMessage = null;
-            ThreadPool.QueueUserWorkItem(delegate
+            _ = ThreadPool.QueueUserWorkItem(delegate
             {
                 string command = $"{verb} {standardArguments} -InstanceId '{DeviceId}'";
                 var result = PowerShell.RunElevated(command);

diff --git a/MainWindow.xaml.cs b/MainWindow.xaml.cs
@@ -36,7 +36,7 @@ private void OnErrorCloseButtonClicked(object sender, RoutedEventArgs e)
 
         private void nameLink_Click(object sender, RoutedEventArgs e)
         {
-            Process.Start("https://github.com/ssg/NoJoy");
+            _ = Process.Start("https://github.com/ssg/NoJoy");
         }
     }
 }
diff --git a/NoJoy.csproj b/NoJoy.csproj
@@ -101,6 +101,7 @@
       <Generator>ResXFileCodeGenerator</Generator>
       <LastGenOutput>Resources.Designer.cs</LastGenOutput>
     </EmbeddedResource>
+    <None Include=".editorconfig" />
     <None Include="app.manifest">
       <SubType>Designer</SubType>
     </None>

diff --git a/WmiControllerEnumerator.cs b/WmiControllerEnumerator.cs
@@ -80,7 +80,7 @@ public MainWindowViewModel GetControllers()
                 Debug.WriteLine($"Testing game controller: {device.FullName}");
 
                 // Saitek hack to identify correct device
-                var newDevice = identifySaitekParent(results, device);
+                var newDevice = identifySaitekParent(device);
                 if (newDevice != null)
                 {
                     device = newDevice;
@@ -92,7 +92,7 @@ public MainWindowViewModel GetControllers()
             return controllers;
         }
 
-        private static DeviceInfo identifySaitekParent(ManagementObjectCollection results, DeviceInfo device)
+        private static DeviceInfo identifySaitekParent(DeviceInfo device)
         {
             if (!device.Name.EndsWith(saitekHidSuffix))
             {