Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop net7.0 target #1468

Merged
merged 6 commits into from
Dec 18, 2024
Merged

Drop net7.0 target #1468

merged 6 commits into from
Dec 18, 2024

Conversation

Rob-Hague
Copy link
Collaborator

.NET 7 is EOL since May. The only .NET 7 features we use are ObjectDisposedException.ThrowIf (moved to a throw helper) and some newer regex features.

This feels a bit weird, but I suppose it is the expected course of action.

.NET 7 is EOL since May. The only .NET 7 features we use are
`ObjectDisposedException.ThrowIf` (moved to a throw helper) and
some newer regex features.

This feels a bit weird, but I suppose it is the expected course of action.
Copy link
Collaborator

@WojciechNagorski WojciechNagorski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make a release without this and merge it later for next release?

@Rob-Hague
Copy link
Collaborator Author

Sure

@drieseng
Copy link
Member

Does it hurt us to keep supporting .NET 7.0? Do we want to be so agressive in removing support for TFMs that are EOL?
+1 for all other changes.

@Rob-Hague
Copy link
Collaborator Author

It is obviously not a great hinderance atm, as there is not much net7.0-specific code. That's also a reason to drop it without ill effect.

IMO it is not much more nuanced than: if Microsoft don't support it, then why should we?

Anyway, let's do another release and re-evaluate for the one after.

@mus65
Copy link
Contributor

mus65 commented Sep 14, 2024

Also note that dropping net7.0 doesn't actually prevent net7.0 applications from using SSH.NET . They will just fall back to the netstandard2.1 net6.0 assembly, which will probably work fine.

# Conflicts:
#	src/Renci.SshNet/BaseClient.cs
#	src/Renci.SshNet/Common/ThrowHelper.cs
#	src/Renci.SshNet/SubsystemSession.cs
@mus65
Copy link
Contributor

mus65 commented Nov 23, 2024

Might want to drop net6.0 as well since it's also EOL. Also netstandard2.1 is imho not worth targeting anymore. I've seen very few libraries targeting it and even MS libraries don't.

# Conflicts:
#	src/Renci.SshNet/Renci.SshNet.csproj
#	test/Renci.SshNet.Tests/Renci.SshNet.Tests.csproj
@Rob-Hague Rob-Hague merged commit 42d75bc into sshnet:develop Dec 18, 2024
3 checks passed
@Rob-Hague Rob-Hague deleted the net7 branch December 18, 2024 17:35
@Rob-Hague
Copy link
Collaborator Author

will do a separate change for net6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants