-
-
Notifications
You must be signed in to change notification settings - Fork 939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use System.Security.Cryptography for TripleDesCipher and fall back to use BouncyCastle if BCL doesn't support #1546
Open
scott-xu
wants to merge
3
commits into
sshnet:develop
Choose a base branch
from
scott-xu:des
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scott-xu
force-pushed
the
des
branch
3 times, most recently
from
December 1, 2024 09:32
eadc5ab
to
232e446
Compare
We could consider dropping DesCipher |
Agree |
scott-xu
changed the title
Use System.Security.Cryptography for DesCipher and TripleDesCipher and falls back to use BouncyCastle if BCL doesn't support
Use System.Security.Cryptography for TripleDesCipher and falls back to use BouncyCastle if BCL doesn't support
Dec 22, 2024
scott-xu
requested review from
drieseng,
WojciechNagorski and
Rob-Hague
as code owners
December 22, 2024 16:03
scott-xu
changed the title
Use System.Security.Cryptography for TripleDesCipher and falls back to use BouncyCastle if BCL doesn't support
Use System.Security.Cryptography for TripleDesCipher and fall back to use BouncyCastle if BCL doesn't support
Dec 22, 2024
…ll back to use BouncyCastle if BCL doesn't support
Might also be a good chance to drop home-made
Further more, we can consider changing all Renci.SshNet.Security.Cryptography.* internal. |
possibly yes, but I would prefer to think about that separately. Can you restore CbcCipherMode here? |
CbcCipherMode is restored. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
TripleDesCipher
to use BCL'sTripleDES
where possible, and falls back to use BoucyCastle if BCL doesn't support.DesCipher
. It is only used to decrypt OpenSSL legacy private key format (aka PKCS1). Suggest switching to newer encryption method.AesCipherMode
toBlockCipherMode
. Some previous discussion: Use hardware-accelerated AES CryptoServiceProvider #865 (comment)Benchmarks based on .NET 9.0.0 (9.0.24.52809), X64 RyuJIT AVX2
Before:
After: