Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to ruff-format from black #1394

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Switch to ruff-format from black #1394

merged 1 commit into from
Sep 12, 2024

Conversation

gadomski
Copy link
Member

Description:

Since we already have ruff for linting, this gets one one fewer dep. Doesn't need a changelog.

Also includes a couple of tweaks to ape https://github.com/astral-sh/ruff-pre-commit/blob/main/.pre-commit-hooks.yaml more exactly but still use the system ruff.

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.

@gadomski gadomski requested a review from jsignell August 21, 2024 19:56
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.19%. Comparing base (e326b41) to head (e06d1bd).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1394   +/-   ##
=======================================
  Coverage   91.19%   91.19%           
=======================================
  Files          52       52           
  Lines        7238     7238           
  Branches     1019     1019           
=======================================
  Hits         6601     6601           
  Misses        457      457           
  Partials      180      180           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with this in theory but it looks like the max line len changed and resulted in most of the file changes. Is there a way to hold it constant so this PR doesn't touch as much of the codebase?

@gadomski
Copy link
Member Author

I am fine with this in theory but it looks like the max line len changed and resulted in most of the file changes.

🤔 did it? This line stayed the same at 88, which is the black default. I think most of the rearrangements are from how parenthesis, commas, and multi-line strings are handled.

@gadomski gadomski added this pull request to the merge queue Sep 12, 2024
Merged via the queue into main with commit a5c3e80 Sep 12, 2024
20 checks passed
@gadomski gadomski deleted the use-ruff-format branch September 12, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants