chore: use dependency-groups #1517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadomski
commented
Feb 3, 2025
Comment on lines
-90
to
-111
| lint: | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| python-version: | ||
| - "3.10" | ||
| - "3.11" | ||
| - "3.12" | ||
| - "3.13" | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: ${{ matrix.python-version }} | ||
| - uses: astral-sh/setup-uv@v5 | ||
| with: | ||
| enable-cache: true | ||
| - name: Sync | ||
| run: uv sync | ||
| - name: Execute linters & type checkers | ||
| run: uv run pre-commit run --all-files | ||
|
|
There was a problem hiding this comment.
I don't feel like we need a separate lint job, moved this to the main check.
.python-version
Outdated
There was a problem hiding this comment.
This gives us a default Python version for uv in CI, but doesn't force it for downstream users or anything.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1517 +/- ##
=======================================
Coverage 91.47% 91.47%
=======================================
Files 54 54
Lines 7542 7542
Branches 915 915
=======================================
Hits 6899 6899
Misses 457 457
Partials 186 186 ☔ View full report in Codecov by Sentry. |
jsignell
approved these changes
Feb 3, 2025
Same. #1518 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
dev-depdendencies are considered legacy now. Also does some cleanup of CI. No CHANGELOG needed.
PR Checklist:
scripts/test)