Tensor support #403
Closed
Tensor support #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisv
reviewed
Nov 18, 2023
.github/workflows/windows-conda.yml
Outdated
| :: Build and Install | ||
| cmake --build . --config Release --target install | ||
| if errorlevel 1 exit 1 | ||
| :: Set old path | ||
| set PATH=%OLD_PATH% | ||
|
|
||
| :: Build stubs | ||
| git clone https://github.com/jcarpent/pybind11-stubgen.git |
There was a problem hiding this comment.
I think the manual stub generation is not mandatory anymore.
Maybe, a better fix should be to modify the path in jrlcmakemodule when calling the stub generator.
|
@jorisv Thanks for finding this issue. Could you integrate an optional argument in the stubs function to automatically inform the PATH variable on Windows? |
|
COuld you make this change in #375? |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.