-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support of numpy 2.0.0b1 #448
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you avoid renaming variables and perform the fix?
@duburcqa Thanks for the contribution to support the latest NumPy change. Yet, it seems important to first extend the support of EigenPy, then change some variable names if they improve the readability. Please make these two stages into two different PRs. |
I will fix support of |
20b0663
to
8a9f0e7
Compare
for more information, see https://pre-commit.ci
The CI is passing ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @duburcqa. Very nice push forward !
## [3.5.0] - 2024-04-14 ### Added - Allow use of installed JRL-cmakemodule (stack-of-tasks/eigenpy#446) - Support of Numpy 2.0.0b1 (stack-of-tasks/eigenpy#448) - Support new primitive type (char, int8_t, uint8_t, int16_t, uint16_t, uint32_t, uint64_t) ()stack-of-tasks/eigenpy#455) - Support conversion between signed <-> unsigned integers (stack-of-tasks/eigenpy#455) - Support conversion between complex numbers (stack-of-tasks/eigenpy#455) ### Fixed - Fix unit test build in C++11 (stack-of-tasks/eigenpy#442) - Fix unit test function signature [#443](stack-of-tasks/eigenpy#443) - Fix CMake export (stack-of-tasks/eigenpy#446) - Fix `int` management on Windows (stack-of-tasks/eigenpy#455) - Fix `long long` management on Mac (stack-of-tasks/eigenpy#455) - Allow to run test in the build directory on Windows (stack-of-tasks/eigenpy#457) ### Removed - Remove casting when converting from Eigen scalar to Numpy scalar. This should not remove any functionality since Numpy array are created from the Eigen scalar type (stack-of-tasks/eigenpy#455)
Thank you both for your hard work here! 🙏 Am curious, when building wheels for 3.5.0 or 3.5.1, were they built with NumPy 1 or 2? |
Numpy 1, there is still work to do to fully support numpy 2 in pre-compiled binaries. |
Ok thanks Alexis! 🙏 |
Fixes #447
It requires a follow-up PR in Boost::Python itself here, but it does not prevent from merging this PR.