Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Handle S3 region #574

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: Handle S3 region #574

wants to merge 3 commits into from

Conversation

NickLarsenNZ
Copy link
Member

@NickLarsenNZ NickLarsenNZ commented Feb 24, 2025

Description

Part of stackabletech/issues#696.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

Comment on lines +628 to +632
data.insert(
MetaStoreConfig::S3_REGION_NAME.to_string(),
s3.region.name().map(String::from),
);

Copy link
Member Author

@NickLarsenNZ NickLarsenNZ Feb 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this ok as is, since it is a BTreeMap<String, Option<String>> (ie, V = Option<_>). Or do we want to make it like this:

if let Some(region_name) = s3.region.name() {
  data.insert(
    MetaStoreConfig::S3_REGION_NAME.to_string(),
    Some(region_name.to_string()),
  );
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant