python: Provide python rules via CrossResolve. #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pcj Is this something that is desirable upstream? |
|
Apologies for the long delay, yes this is desireable. Let's look to get it rebased. |
This allows rules_python's gazelle plugin to find python rules generated by rules_proto allowing for a fully gazelle'ified experience working with protos with Python.
DolceTriade
force-pushed
the
provide_python
branch
from
788c032 to
6af26de
Compare
|
Rebased. Also ran gazelle. |
|
LGTM. Seems like the github actions CI setup needs to run gazelle and check for no diff. |
|
Should I undo the irrelevant gazelle changes? |
|
No it’s fine, just not something you should not have to think about.
…---
Paul Cody Johnston
Principal - Stack.Build
On Tue, Feb 20, 2024 at 2:19 PM DolceTriade ***@***.***> wrote:
Should I undo the irrelevant gazelle changes?
—
Reply to this email directly, view it on GitHub
<#316 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAMLFBYH2ZIZ62GE65IN4LYUUHMVAVCNFSM6AAAAAAWSFEQJGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJVGEYTKMRSHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
CI is failing, but it's not due to this PR. I'm going to merge this and disable that test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows rules_python's gazelle plugin to find python rules generated by rules_proto allowing for a fully gazelle'ified experience working with protos with Python.