Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronise zed with upstream #63

Open
wants to merge 13 commits into
base: stackhpc/zed
Choose a base branch
from

Commits on Jul 10, 2024

  1. Fix import job to provide valid disk-formats list to tempest

    Recent changes does not allow image conversion to convert an image
    having AMI disk format for image. Passing list of disk-formats to
    each import job which will now use qcow2 as default disk-format to
    create the image.
    
    Change-Id: I712b304ebe168705ec2793626f5d64135ad6d458
    (cherry picked from commit 244ccb6)
    (cherry picked from commit f98e9ae)
    konan-abhi authored and Elod Illes committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    02732c2 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Support Stream Optimized VMDKs

    Stream optimized VMDKs are also monolithic disks images, and start
    with the same sparse extend header as normal monolithic sparse files,
    so we can parse the virtual disk size in the same manner.
    
    See "VMware Virtual Disks Virtual Disk Format 1.1" p. 17.
    > Header and Footer
    > The header and the footer are both described by the same SparseExtentHeader
    > structure shown in Hosted Sparse Extent Header on page 8.
    
    Closes-Bug: #2052291
    Change-Id: I7d63951ff080dc699b8d11babc0a5998d90621e4
    Co-Authored-By: Rajiv Mucheli <[email protected]>
    (cherry picked from commit 5e7e6bf)
    (cherry picked from commit 9d45e8d4b87e992be23974a831811bff563ce721)
    (cherry picked from commit ef22a74)
    fwiesel authored and mnaser committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    bcfc1e4 View commit details
    Browse the repository at this point in the history
  2. Reject qcow files with data-file attributes

    Change-Id: I6326a3e85c1ba4cb1da944a4323769f2399ed2c1
    Closes-Bug: #2059809
    (cherry picked from commit 2ca29af4433e9fa99a0a48e230d8d25d6eaa4a87)
    (cherry picked from commit c3586f3a122f6cb0663217b12b52203e74e2e4fa)
    (cherry picked from commit a92c438fb5ba55440b38cae7c8b4361b58daa9dd)
    (cherry picked from commit dba3bdb)
    kk7ds authored and mnaser committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    6a38aef View commit details
    Browse the repository at this point in the history
  3. Extend format_inspector for QCOW safety

    This adds two properties to the QcowInspector that makes it able to
    indicate whether the file specifies a backing_file or data_file in the
    header. Both conditions are considered unsafe for our usage. To
    ease checking of this condition, a classmethod is added that takes
    a local filename and digests just enough of the file to assert that
    both conditions are false.
    
    Change-Id: Iaf86b525397d41bd116999cabe0954a0a7efac65
    Related-Bug: #2059809
    (cherry picked from commit ae536bb394793c9a7a219cb498e03d5c81dbbbb7)
    (cherry picked from commit 2eba54e0821106097dfeceb424e53943fd090483)
    (cherry picked from commit 89dbbc838d606f461087e1494d19ddbcf9db0a38)
    (cherry picked from commit 4860024)
    kk7ds authored and mnaser committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    f32d5b8 View commit details
    Browse the repository at this point in the history
  4. Add VMDK safety check

    This makes us check the extent filenames to make sure they don't
    have any banned characters in them (i.e. slashes). It also makes
    us reject VMDK files with a footer. Since we process these files
    as a stream, we can't honor a footer that directs us to find the
    descriptor block in a location we've already processed. Thus, if
    a file indicates it has a footer, consider it a policy exception
    and unsupported.
    
    Change-Id: I4a1c6dff7854c49940a0ac7988722aa6befc04fa
    (cherry picked from commit c1bf35dffb7f4c3090b1f04cf0e27cb431330c3e)
    (cherry picked from commit d3f1d6159c0218ac01e8d881e2ec4da71fc952ee)
    (cherry picked from commit 2dd4d138d4b8e1d9ca69fc0dda3711553a65d912)
    (cherry picked from commit 812e56d)
    kk7ds authored and mnaser committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    05650e1 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. Merge "Fix import job to provide valid disk-formats list to tempest" …

    …into unmaintained/zed
    Zuul authored and openstack-gerrit committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    0ec7058 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ad7de73 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8806c83 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Configuration menu
    Copy the full SHA
    0d2c684 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d4ab3b8 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Reject unsafe qcow and vmdk files

    This causes us to use the format inspector to pre-examine qcow and
    vmdk files for safe configurations before even using qemu-img
    on them.
    
    Depends-On: https://review.opendev.org/c/openstack/glance/+/923861
    Change-Id: I0554706368e573e11f649c09569f7c21cbc8634b
    Closes-Bug: #2059809
    (cherry picked from commit a95f335bca1dfdd1c904ae475e9fe8c6806f2c56)
    (cherry picked from commit 55fc42563818fcf88b474233df242a796c918b3a)
    (cherry picked from commit f1f53075d69a9a1c006b3e25506e30eb0210de1f)
    (cherry picked from commit c1c54ab)
    kk7ds authored and elajkat committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    63ac35e View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Add QED format detection to format_inspector

    This merely recognizes this format and always marks it as unsafe
    because no service supports it. This prevents someone from uploading
    one that we will ask qemu-img to inspect.
    
    Change-Id: Ieea7b7eb0f380571bd4937cded920776e05f7ec4
    (cherry picked from commit 4096c5aff1d046d5c28d0e4a69b3c9574e9e8cc8)
    (cherry picked from commit ba98022b98ef5b9c98e1d7d20c88e1ca4b23fa80)
    (cherry picked from commit a8dadcd7994c88a61f94341286b4bcd693b51b32)
    (cherry picked from commit 9b3faf3)
    kk7ds authored and mnaser committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    f83f0bf View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Add file format detection to format_inspector

    Change-Id: If0a4251465507be035ffaf9d855299611637cfa9
    (cherry picked from commit 79271eaa5c742a1741321198c43807857fb6ed94)
    (cherry picked from commit e1c36248c7660dea1bedfa8f1c0711a4b97d279c)
    (cherry picked from commit d54121d6a937fd50aae1018aede228a3c0985dce)
    (cherry picked from commit 1656fe8)
    kk7ds authored and mnaser committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    8bbe205 View commit details
    Browse the repository at this point in the history