Train ossa 2023 002 #26
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not supported on Python 3.8 [1]. I have no idea why this was not failing CI. [1] https://docs.python.org/3.9/library/stdtypes.html#str.removeprefix Change-Id: I225e9ced0f75c415b1d2fee05440291e3d8635c0 Signed-off-by: Stephen Finucane <[email protected]>
This is mostly code motion from the nova.virt.images module into privsep to allow for both privileged and unprivileged calls to be made. A privileged_qemu_img_info function is introduced allowing QEMU to access devices requiring root privileges, such as host block devices. Change-Id: I5ac03f923d9d181d22d44d8ec8fbc31eb0c3999e
This will allow for the use of the JSON output format that is easier to parse within QemuImgInfo and should allow additional information to be extracted from qemu-img calls in the future. Change-Id: I0b6d1a98726ffa1ebc78fb3c4563a2e4b40ddeff
This change is a follow up to I0c3f14100a18107f7e416293f3d4fcc641ce5e55 and removes the direct call to nova.privsep.qemu with one to the images API that now returns an oslo_utils.imageutils.QemuImgInfo object. Version 4.1.0 of oslo.utils introducing support for the format-specific data returned by qemu-img info for LUKSv1 based images. Change-Id: I573396116e10cf87f80f1ded55f2cd8f498859e4 Conflicts, mostly missing extend encrpyted volumes: lower-constraints.txt nova/tests/unit/virt/libvirt/test_driver.py nova/virt/libvirt/driver.py Change-Id: I8754875e54822a8d132e16c44ccf9e98514b4e3b
The updated minimum required libvirt (4.0.0) and QEMU (2.11) for "Ussuri" satisfy the version requirements; this was done in Change-Id: Ia18e9be4d (22c1916 — libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION for "Ussuri", 2019-11-19). Drop the version constant QEMU_VERSION_REQ_SHARED and now-needless compatibility code; adjust/remove tests. Change-Id: If878a023c69f25a9ea45b7de2ff9eb1976aaeb8c Signed-off-by: Stephen Finucane <[email protected]>
oslo.utils is planning to make JSON the default output format parsed when creating QemuImgInfo objects. As such this change makes JSON the default output_format requested when calling qemu-img info. The majority of this change is actually test removal from nova.tests.unit.virt.libvirt.test_utils as these human readable qemu-img based tests now duplicate tests found in oslo.utils itself. Change-Id: I56676713571e79f05ee3f0bffc5da8386e02c5d4 Conflicts: nova/tests/unit/virt/libvirt/test_driver.py nova/tests/unit/virt/test_images.py nova/virt/libvirt/driver.py Change-Id: I29fa320fdef9553cab046a501778fabbe48c1478
NOTE(sbauza): Stable policy allows us to proactively merge a backport without waiting for the parent patch to be merged (exception to rule #4 in [1]. Marking [stable-only] in order to silence nova-tox-validate-backport [1] https://docs.openstack.org/project-team-guide/stable-branches.html#appropriate-fixes Conflicts vs victoria in: nova/conf/compute.py Related-Bug: #1996188 Change-Id: I5a399f1d3d702bfb76c067893e9c924904c8c360
Change-Id: I26772876a2e325dba98aef457294c631f972b3aa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.