Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rated dwpd alerts #1077

Open
wants to merge 3 commits into
base: stackhpc/2023.1
Choose a base branch
from
Open

Rated dwpd alerts #1077

wants to merge 3 commits into from
+183 −25

Conversation

technowhizz
Copy link
Contributor

This PR allows the operator to specify the rated DWPD of a disk and have it show up in prometheus

@technowhizz technowhizz requested a review from jovial May 16, 2024 17:40
@technowhizz technowhizz self-assigned this May 16, 2024
@technowhizz technowhizz requested a review from a team as a code owner May 16, 2024 17:40
@technowhizz technowhizz requested a review from jovial June 12, 2024 14:28
dougszumski
dougszumski requested changes Jun 21, 2024
View reviewed changes
Copy link
Member

@dougszumski dougszumski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent piece of work @technowhizz . Please see if you can simplify it by writing out the DWPD file separately. Unless I've missed something?

etc/kayobe/ansible/get-nvme-drives.yml Show resolved Hide resolved
etc/kayobe/ansible/get-nvme-drives.yml
command: "nvme list -o json"
register: nvme_list
changed_when: false
become: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Is root required? At least on Fedora 40 it doesn't appear to be. Feel free to ignore if you're not sure.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if all disks are listed if not root

etc/kayobe/ansible/get-nvme-drives.yml Show resolved Hide resolved
etc/kayobe/ansible/smartmon-tools.yml

- name: Create a DWPD ratings file
copy:
content: |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could just be the raw file that you write out above when running the playbook?

etc/kayobe/ansible/scripts/nvmemon.sh Show resolved Hide resolved
@Alex-Welsh
Copy link
Contributor

@technowhizz what do we need to do to get this moving again? It looks like a lot of work and I don't want it to go to waste

@dougszumski
Copy link
Member

@technowhizz what do we need to do to get this moving again? It looks like a lot of work and I don't want it to go to waste

Now we have started on the Python script it makes sense to finish that first and then come back to this.

@Alex-Welsh Alex-Welsh added enhancement New feature or request antelope Targets the Antelope OpenStack release monitoring All things related to observability & telemetry labels Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougszumski dougszumski dougszumski requested changes

@jovial jovial Awaiting requested review from jovial

Requested changes must be addressed to merge this pull request.

Assignees

@technowhizz technowhizz

Labels
antelope Targets the Antelope OpenStack release enhancement New feature or request monitoring All things related to observability & telemetry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@technowhizz @Alex-Welsh @dougszumski @jovial