ROX-27634: Improvements to CollectorConfig protobuf definitions #1998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoukoVirtanen
force-pushed
the
jv-update-CollectorConfig-protobuf
branch
from
29d9278 to
a8909a2
Compare
JoukoVirtanen
changed the base branch from
master
to
jv-ROX-27396-collector-configloader-should-not-need-to-be-modified-when-the-protobuf-is
JoukoVirtanen
force-pushed
the
jv-update-CollectorConfig-protobuf
branch
from
8ec3ee1 to
60640e4
Compare
JoukoVirtanen
changed the base branch from
jv-ROX-27396-collector-configloader-should-not-need-to-be-modified-when-the-protobuf-is
to
master
JoukoVirtanen
changed the title
9 tasks
Stringy
reviewed
Jan 13, 2025
Stringy
reviewed
Jan 13, 2025
Co-authored-by: Giles Hutton <[email protected]>
Stringy
reviewed
Jan 14, 2025
Stringy
reviewed
Jan 14, 2025
JoukoVirtanen
changed the title
Stringy
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It was suggested in the PR to set collector runtime config via helm charts that
networking.external_ips.enableshould be changed tonetworking.external_ips.enabled. The protobuf definitions tend to use enabled rather than enable. The same is true for the helm charts. The boolean datatype should be changed to an enum. per_container_rate_limit should be changed to max_connections_per_minute.Even if these are never set using helm or operator, it is still good to make these changes.
These protobufs are internal and the feature that uses them is in technical preview. The collector expects the field to be
enablerather thanenabledin the collector-config ConfigMap. Some customers may have this setting, but as stated earlier this is in technical preview, use in production is not recommended, and customers should not expect this to be stable.The PR that updated the protobuf definitions in stackrox/stackrox is here stackrox/stackrox#13608
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
Unit tests and integration tests were modified. No new tests were needed and CI is sufficient.