Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image build segfaults on QEMU #2018

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Fix image build segfaults on QEMU #2018

merged 2 commits into from
Jan 29, 2025

Conversation

Molter73
Copy link
Collaborator

@Molter73 Molter73 commented Jan 27, 2025

Description

Collector build randomly started failing on ppc64le and arm64 with the following segfault message:

gmake[2]: *** [driver/modern_bpf/CMakeFiles/ProbeSkeleton.dir/build.make:673: driver/modern_bpf/copy_file_range.bpf.o] Segmentation fault (core dumped)
gmake[1]: *** [CMakeFiles/Makefile2:2035: driver/modern_bpf/CMakeFiles/ProbeSkeleton.dir/all] Error 2
gmake[1]: *** Waiting for unfinished jobs....

The error itself seems to coincide with an update to the GHA runner which updates the kernel:

Because the errors are specific to ppc64le and arm64 builds, the best guess is that there is an incompatibility between QEMU and this newer kernel. The proposed fix is to update the image used for setting up QEMU.

Checklist

  • Investigated and inspected CI test results
  • Updated documentation accordingly

Automated testing

  • Added unit tests
  • Added integration tests
  • Added regression tests

If any of these don't apply, please comment below.

Testing Performed

Run all affected jobs on CI.

@Molter73 Molter73 added the run-multiarch-builds Run steps for non-x86 archs. label Jan 27, 2025
@Molter73 Molter73 changed the title [WIP] Investigate gcc segfault under QEMU Fix image build segfaults on QEMU Jan 28, 2025
@Molter73 Molter73 marked this pull request as ready for review January 28, 2025 10:42
@Molter73 Molter73 requested a review from a team as a code owner January 28, 2025 10:42
Copy link
Collaborator

@Stringy Stringy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Changes look fine in isolation and happy to approve while the build is currently running based on the previously successful run in https://github.com/stackrox/collector/actions/runs/12993387769/job/36235634078

@Molter73 Molter73 merged commit d6c3434 into master Jan 29, 2025
94 of 111 checks passed
@Molter73 Molter73 deleted the mauro/gcc-segfault branch January 29, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-multiarch-builds Run steps for non-x86 archs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants