Add OpenShift DeploymentConfig schema (#153)

Co-authored-by: Stan Kozlov <[email protected]> Co-authored-by: Cereberus <[email protected]>
stackrox · Apr 7, 2021 · a8478ee · a8478ee
1 parent b614a5d
commit a8478ee
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 3 deletions.
diff --git a/go.mod b/go.mod
@@ -9,6 +9,7 @@ require (
 	github.com/ghodss/yaml v1.0.0
 	github.com/golangci/golangci-lint v1.30.0
 	github.com/mitchellh/mapstructure v1.1.2
+	github.com/openshift/api v3.9.0+incompatible
 	github.com/pkg/errors v0.9.1
 	github.com/spf13/cobra v1.1.1
 	github.com/spf13/viper v1.7.0

diff --git a/go.sum b/go.sum
@@ -646,6 +646,8 @@ github.com/opencontainers/runc v0.0.0-20190115041553-12f6a991201f/go.mod h1:qT5X
 github.com/opencontainers/runc v0.1.1/go.mod h1:qT5XzbpPznkRYVz/mWwUaVBUv2rmF59PVA73FjuZG0U=
 github.com/opencontainers/runtime-spec v0.1.2-0.20190507144316-5b71a03e2700/go.mod h1:jwyrGlmzljRJv/Fgzds9SsS/C5hL+LL3ko9hs6T5lQ0=
 github.com/opencontainers/runtime-tools v0.0.0-20181011054405-1d69bd0f9c39/go.mod h1:r3f7wjNzSs2extwzU3Y+6pKfobzPh+kKFJ3ofN+3nfs=
+github.com/openshift/api v3.9.0+incompatible h1:fJ/KsefYuZAjmrr3+5U9yZIZbTOpVkDDLDLFresAeYs=
+github.com/openshift/api v3.9.0+incompatible/go.mod h1:dh9o4Fs58gpFXGSYfnVxGR9PnV53I8TW84pQaJDdGiY=
 github.com/opentracing-contrib/go-observer v0.0.0-20170622124052-a52f23424492/go.mod h1:Ngi6UdF0k5OKD5t5wlmGhe/EDKPoUM3BXZSSfIuJbis=
 github.com/opentracing/basictracer-go v1.0.0/go.mod h1:QfBfYuafItcjQuMwinw9GhYKwFXS9KnPs5lxoYwgW74=
 github.com/opentracing/opentracing-go v1.0.2/go.mod h1:UkNAQd3GIcIGf0SeVgPpRdFStlNbqXla1AfSYxPUl2o=

diff --git a/pkg/lintcontext/parse_yaml.go b/pkg/lintcontext/parse_yaml.go
@@ -3,13 +3,15 @@ package lintcontext
 import (
 	"bufio"
 	"bytes"
+	"fmt"
 	"io"
 	"log"
 	"os"
 	"path/filepath"
 	"strings"
 
 	y "github.com/ghodss/yaml"
+	ocsAppsV1 "github.com/openshift/api/apps/v1"
 	"github.com/pkg/errors"
 	"golang.stackrox.io/kube-linter/internal/k8sutil"
 	"helm.sh/helm/v3/pkg/chart"
@@ -31,10 +33,20 @@ const (
 )
 
 var (
-	clientSchema = scheme.Scheme
-	decoder      = serializer.NewCodecFactory(clientSchema).UniversalDeserializer()
+	decoder runtime.Decoder
 )
 
+func init() {
+	clientScheme := scheme.Scheme
+
+	// Add OpenShift schema
+	schemeBuilder := runtime.NewSchemeBuilder(ocsAppsV1.AddToScheme)
+	if err := schemeBuilder.AddToScheme(clientScheme); err != nil {
+		panic(fmt.Sprintf("Can not add OpenShift schema %v", err))
+	}
+	decoder = serializer.NewCodecFactory(clientScheme).UniversalDeserializer()
+}
+
 func parseObjects(data []byte, d runtime.Decoder) ([]k8sutil.Object, error) {
 	if d == nil {
 		d = decoder
@@ -243,5 +255,4 @@ func (l *lintContextImpl) loadObjectsFromReader(filePath string, reader io.Reade
 			return err
 		}
 	}
-
 }
diff --git a/pkg/objectkinds/deployment_like.go b/pkg/objectkinds/deployment_like.go
@@ -3,6 +3,7 @@ package objectkinds
 import (
 	"fmt"
 
+	ocsAppsV1 "github.com/openshift/api/apps/v1"
 	appsV1 "k8s.io/api/apps/v1"
 	batchV1 "k8s.io/api/batch/v1"
 	batchV1Beta1 "k8s.io/api/batch/v1beta1"
@@ -16,6 +17,7 @@ var (
 		for _, gk := range []schema.GroupKind{
 			{Group: appsV1.GroupName, Kind: "Deployment"},
 			{Group: appsV1.GroupName, Kind: "DaemonSet"},
+			{Group: ocsAppsV1.GroupName, Kind: "DeploymentConfig"},
 			{Group: appsV1.GroupName, Kind: "StatefulSet"},
 			{Group: appsV1.GroupName, Kind: "ReplicaSet"},
 			{Group: coreV1.GroupName, Kind: "Pod"},