ROX-27384: Use the updated determine-image-tag task
#1771
+20
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because the inline check is part of `determine-image-tag` task and because `SCANNER_TAG`/`RELEASE_TAG` is always explicitly injected in `BUILD_ARGS` and Dockerfile. The latter means Makefile will use the `RELEASE_TAG` value instead of trying to run `git` command.
so that it can be copied verbatim to release branches. I.e. there will be no diff in CEL expressions between `master` and `release-*` branches with such a CEL expression. Less diff -> simpler life when setting up release.
|
Skipping CI for Draft Pull Request. |
msugakov
force-pushed
the
misha/ROX-27384-update-determine-tag-konflux-task
branch
from
d365cfc to
62da3ff
Compare
|
/retest scanner-db-slim-on-push |
|
/retest scanner-slim-on-push |
msugakov
added
the
backport-for-4.6-konflux-release
4 tasks
tommartensen
approved these changes
Jan 17, 2025
|
@msugakov: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The task from stackrox/konflux-tasks#16 is used.
Perhaps it's better to review this change by commits.
Testing Performed
Validated with a few runs that tags come out as expected:
2.35.x-47-g62da3fffbc-fastmisha-test-2-fastmisha-test-2-0-gd365cfcc0f-fastmisha-test-1-fastmisha-test-a-fastmisha-test-1-0-g06b53abda6-fastNote that I cleaned up tags by the time of publishing this PR.