Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-27402: CVE data model update image store pr 5 #13864

Draft
wants to merge 99 commits into
base: dashrews/cve-data-model-create-datastore-27526-PR-4
Choose a base branch
from

Conversation

dashrews78
Copy link
Contributor

@dashrews78 dashrews78 commented Jan 17, 2025

Description

Updates to the image store to populate the data for the updated model.

PR 1 is #13681
PR 2 is #13682
PR 3 is #13704
PR 4 is #13707
PR 5 is #13864 -- This PR

User-facing documentation

  • CHANGELOG is updated OR update is not needed
  • documentation PR is created and is linked above OR is not needed

Testing and quality

  • the change is production ready: the change is GA or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

change me!

Copy link

openshift-ci bot commented Jan 17, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rhacs-bot
Copy link
Contributor

rhacs-bot commented Jan 17, 2025

Images are ready for the commit at b542b4e.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.7.x-693-gb542b4e00c.

@dashrews78 dashrews78 force-pushed the dashrews/cve-data-model-create-datastore-27526-PR-4 branch from 752c684 to bd5a5da Compare January 21, 2025 15:33
@dashrews78 dashrews78 force-pushed the dashrews/cve-data-model-update-image-store-27402-PR-5 branch from a0e92ad to b3e9984 Compare January 21, 2025 15:47
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 2.81174% with 795 lines in your changes missing coverage. Please review.

Project coverage is 48.58%. Comparing base (bd5a5da) to head (9865793).

Files with missing lines Patch % Lines
central/image/datastore/store/v2/postgres/store.go 0.00% 771 Missing ⚠️
pkg/postgres/schema/images.go 46.15% 12 Missing and 2 partials ⚠️
central/image/datastore/singleton.go 0.00% 7 Missing ⚠️
central/image/datastore/store/postgres/store.go 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@                                   Coverage Diff                                   @@
##           dashrews/cve-data-model-create-datastore-27526-PR-4   #13864      +/-   ##
=======================================================================================
- Coverage                                                48.79%   48.58%   -0.21%     
=======================================================================================
  Files                                                     2499     2500       +1     
  Lines                                                   181052   181844     +792     
=======================================================================================
+ Hits                                                     88338    88349      +11     
- Misses                                                   85701    86484     +783     
+ Partials                                                  7013     7011       -2     
Flag Coverage Δ
go-unit-tests 48.58% <2.81%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dashrews78 dashrews78 force-pushed the dashrews/cve-data-model-create-datastore-27526-PR-4 branch from bd5a5da to 28b6964 Compare January 24, 2025 16:44
@dashrews78 dashrews78 force-pushed the dashrews/cve-data-model-update-image-store-27402-PR-5 branch from 9865793 to cdeceb3 Compare January 24, 2025 16:45
a813477 proto updates
7dea12b update protolock
78d6320 rename to V2
39c4c44bf1 add architecture
a813477 proto updates
7dea12b update protolock
78d6320 rename to V2
d8f2311 starting convertors
8ddb043 convertors
d3fc60d some more conversions
1df7e88 rough UT
ec246df Update IDs and testing
ccc3f69 generate component store
479e4cb datastore functions
0cf749c generate mocks
4f0e467 update test and flag singleton
6107c84e21 messing with image store
a502e566be store and merge work
1901849dc8 fix import
451e69a91f fields that need to not be overwritten
8eb180b238 clean
903a8a4d68 rebase and regen
2877f29921 add epss
3c394619b1 pulling in epss converters
a0e92ad move metrics and fix test
da25afc339 working on store
0415072 first cut at updating vuln state
cb7c4d9 ff for image schema for now
1ec4be4 format
9865793 some framework tests
@dashrews78 dashrews78 force-pushed the dashrews/cve-data-model-update-image-store-27402-PR-5 branch from cdeceb3 to b542b4e Compare January 24, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants