Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[miner] Miner should issue a tenure extend if the incoming miner fails to produce a block proposal #5729

Open
jferrant opened this issue Jan 21, 2025 · 1 comment
Assignees
Milestone

Comments

@jferrant
Copy link
Collaborator

jferrant commented Jan 21, 2025

Signers will already accept tenure extends from an previous miner if the current miner is marked InvalidatedBeforeFirstBlock (this occurs if the current miner fails to send a single block proposal within block_proposal_timeout_ms which is defaulted to 10 minutes)

The previous miner should watch for block proposals from the incoming miner and if it doesn't see one/stacks chain tip doesn't advance etc. within some timeout, should attempt to tenure extend.

Could in theory not even bother with observing the miner's behaviour and if the stacks tip just doesn't advance within 10 minutes of the incoming miner's tenure starting...issue a tenure extend, but this could result in a prior miner issuing tenure extends that would never get accepted (for example, the incoming miner could have proposed an invalid block proposal immediately, but this would prevent the prior miner from ever being able to extend regardless of the fact that the signers rejected the incoming miner's proposal and the tip has not advanced)

@jferrant jferrant added this to the 3.1.0.0.5 milestone Jan 21, 2025
@github-project-automation github-project-automation bot moved this to Status: 🆕 New in Stacks Core Eng Jan 21, 2025
@jferrant jferrant moved this from Status: 🆕 New to Status: 📋 Backlog in Stacks Core Eng Jan 21, 2025
@jferrant jferrant changed the title [miner] Miner should issue a tenure extend if the incoming miner fails to produce a block [miner] Miner should issue a tenure extend if the incoming miner fails to produce a block proposal Jan 21, 2025
@aldur
Copy link
Contributor

aldur commented Jan 29, 2025

As discussed in the sync and referring #5753 the corresponding PR here should set the default value of block_proposal_timeout_ms to something lower than 10m (or 4h, as it will be set before this gets merged).

obycode added a commit that referenced this issue Jan 29, 2025
Until #5729 is implemented, then there is no point in rejecting a block
from a miner, no matter how late it is, since no other miner will ever
try to extend into its tenure.

Fixes #5753
@aldur aldur moved this from Status: 📋 Backlog to Status: In Review in Stacks Core Eng Jan 30, 2025
@aldur aldur moved this from Status: In Review to Status: 💻 In Progress in Stacks Core Eng Jan 30, 2025
@jferrant jferrant self-assigned this Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Status: 💻 In Progress
Development

No branches or pull requests

2 participants