Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust default block_proposal_timeout_ms #5753

Open
obycode opened this issue Jan 27, 2025 · 0 comments
Open

Adjust default block_proposal_timeout_ms #5753

obycode opened this issue Jan 27, 2025 · 0 comments
Milestone

Comments

@obycode
Copy link
Contributor

obycode commented Jan 27, 2025

For the next release, we should adjust the signer config parameter block_proposal_timeout_ms one way or another.

If we are able to include the miner changes in #5729, then the default value for this parameter should be lower than 10 minutes.

If we do not include that miner change in the release, then block_proposal_timeout_ms should default to something very high, e.g. 4 hours, since there is no chance of the previous miner mining a tenure extend, so we should not reject a late valid block from the current miner.

@obycode obycode added this to the 3.1.0.0.5 milestone Jan 27, 2025
@github-project-automation github-project-automation bot moved this to Status: 🆕 New in Stacks Core Eng Jan 27, 2025
obycode added a commit that referenced this issue Jan 29, 2025
Until #5729 is implemented, then there is no point in rejecting a block
from a miner, no matter how late it is, since no other miner will ever
try to extend into its tenure.

Fixes #5753
@obycode obycode moved this from Status: 🆕 New to Status: In Review in Stacks Core Eng Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Status: In Review
Development

No branches or pull requests

1 participant