Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix int_plus_one warnings #5626

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Fix int_plus_one warnings #5626

wants to merge 8 commits into from

Conversation

jferrant
Copy link
Collaborator

No description provided.

@jferrant
Fix int_plus_one warnings
a94ee8d 
Signed-off-by: Jacinta Ferrant <[email protected]>
@jferrant jferrant requested a review from a team as a code owner December 31, 2024 18:13
@jferrant jferrant mentioned this pull request Dec 31, 2024
Closed
jbencin
jbencin previously approved these changes Dec 31, 2024
View reviewed changes
obycode
obycode previously approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

jcnelson
jcnelson previously approved these changes Jan 2, 2025
View reviewed changes
@jferrant jferrant dismissed stale reviews from jcnelson, obycode, and jbencin via 680010d January 2, 2025 23:05
obycode
obycode previously approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jferrant
Merge branch 'develop' of https://github.com/stacks-network/stacks-core…
5445fc6 
… into fix/clippy-ci-stacks-lib-int-plus-one
jcnelson
jcnelson requested changes Jan 3, 2025
View reviewed changes
Copy link
Member

@jcnelson jcnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

jbencin
jbencin previously approved these changes Jan 3, 2025
View reviewed changes
@jferrant
Merge branch 'develop' of https://github.com/stacks-network/stacks-core…
a83067d 
… into fix/clippy-ci-stacks-lib-int-plus-one
@jferrant jferrant dismissed stale reviews from jbencin and obycode via a83067d January 4, 2025 01:38
@jferrant
Merge branch 'develop' of https://github.com/stacks-network/stacks-core…
f702204 
… into fix/clippy-ci-stacks-lib-int-plus-one
@jbencin jbencin added the lint Related to linting/clippy/cargo warns label Jan 23, 2025
@obycode obycode enabled auto-merge January 23, 2025 19:15
@jferrant
Copy link
Collaborator Author

@jcnelson are you satisfied with the explanation? Don't want to dismiss your review without confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obycode obycode obycode approved these changes

@jbencin jbencin jbencin approved these changes

@hstove hstove Awaiting requested review from hstove

@jcnelson jcnelson Awaiting requested review from jcnelson

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
lint Related to linting/clippy/cargo warns
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jferrant @jcnelson @obycode @jbencin