fix: signerDB index improvements #5811
Open
+38
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hstove
force-pushed
the
feat/signer-indexes
branch
from
b13de1d to
6405b3a
Compare
obycode
reviewed
Feb 6, 2025
| @@ -545,9 +559,14 @@ static SCHEMA_7: &[&str] = &[ | |||
| "INSERT OR REPLACE INTO db_config (version) VALUES (7);", | |||
| ]; | |||
|
|
|||
| static SCHEMA_8: &[&str] = &[ | |||
| CREATE_INDEXES_8, | |||
| "INSERT OR REPLACE INTO db_config (version) VALUES (8);", | |||
There was a problem hiding this comment.
I realized when looking over the DBs, that this still doesn't do what we intended, to only have one entry in the db_config table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a few new indexes for queries that weren't "perfectly" indexed. For example, queries that didn't have an explicit descending compound index would still result in inefficient scans.
I've confirmed that these indexes will help via running
EXPLAIN QUERY PLAN, but I haven't proven that this will "fix" the growing IOPS issue we see in production instances. For that, I think we'll want to test this out on a live signer with a larger DB.