Fix: enable patient block commits #5835
Open
+514
−361
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a number of things to achieve #5821:
Tests
This PR doesn't add new integration tests (it includes new unit tests for the burn block timeout, though). Instead, it reconfigures and adds assertions to two nakamoto integrations tests to make sure that:
Setting the default timeout
I collected log data from a stacks-node (running a mock miner) to see how much time there was between processing a sortition in the relayer thread (which the miner uses to issue commits) and the first block from that tenure being processed by the coordinator.
The log lines I was interested in were:
After downloading a JSON dump of these from a grafana/loki collector:
The resulting data:
So, the median time is 39 seconds, which informs the 40 second setting in this PR.